    1   package test.net.sourceforge.pmd.rules;
    2
    3   import net.sourceforge.pmd.PMD;
    4   import net.sourceforge.pmd.Rule;
    5   import net.sourceforge.pmd.RuleSetNotFoundException;
    6   import test.net.sourceforge.pmd.testframework.SimpleAggregatorTst;
    7   import test.net.sourceforge.pmd.testframework.TestDescriptor;
    8
    9   public class MisplacedNullCheckTest extends SimpleAggregatorTst {
    10      private Rule rule;
    11
    12      public void setUp() throws RuleSetNotFoundException {
    13          rule = findRule("basic", "MisplacedNullCheck");
    14      }
    15
    16      public void testAll() {
    17          runTests(new TestDescriptor[]{
    18              new TestDescriptor(TEST1, "null check after method invocation", 1, rule),
    19              new TestDescriptor(TEST2, "null check after nested method invocation", 1, rule),
    20              new TestDescriptor(TEST3, "null check before nested method invocation", 0, rule),
    21          });
    22      }
    23
    24      private static final String TEST1 =
    25              "public class Foo {" + PMD.EOL +
    26              " void bar() {" + PMD.EOL +
    27              "  if (a.equals(baz) && a!=null) {}" + PMD.EOL +
    28              " }" + PMD.EOL +
    29              "}";
    30
    31      private static final String TEST2 =
    32              "public class Foo {" + PMD.EOL +
    33              " void bar() {" + PMD.EOL +
    34              "  if (a.equals(baz.foo()) && baz != null) {}" + PMD.EOL +
    35              " }" + PMD.EOL +
    36              "}";
    37
    38      private static final String TEST3 =
    39              "public class Foo {" + PMD.EOL +
    40              " void bar() {" + PMD.EOL +
    41              "  if (a != null && a.equals(foo())) {}" + PMD.EOL +
    42              " }" + PMD.EOL +
    43              "}";
    44
    45  }